Check Service and Resource name maximum length #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlansley
approved these changes
Jan 28, 2025
carlansley
requested changes
Jan 28, 2025
|
|
||
| const MAXIMUM_SERVICE_NAME_LENGTH = 20; | ||
| const SERVICE_NAME_LENGTH_EXCEPTIONS = new Set([ | ||
| 'current-certification', |
There was a problem hiding this comment.
move to env variable or parameter
|
Converted to environment variables, ready for another look |
carlansley
approved these changes
Feb 6, 2025
|
✅ PR review status - All reviews completed and approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80
I went with some stricter limits on service names and s3 buckets with some exceptions for current cases we have. Open to alternative ideas.
Additionally: Had to make unrelated changes to a couple of tests as what was in main was no longer passing tests - coverage test will have to be temporary removed for merging